Page MenuHomePhabricator

Make the Files "TTL" API more structured
ClosedPublic

Authored by epriestley on Apr 4 2017, 7:28 PM.

Details

Summary

Ref T11357. When creating a file, callers can currently specify a ttl. However, it isn't unambiguous what you're supposed to pass, and some callers get it wrong.

For example, to mean "this file expires in 60 minutes", you might pass either of these:

  • time() + phutil_units('60 minutes in seconds')
  • phutil_units('60 minutes in seconds')

The former means "60 minutes from now". The latter means "1 AM, January 1, 1970". In practice, because the GC normally runs only once every four hours (at least, until recently), and all the bad TTLs are cases where files are normally accessed immediately, these 1970 TTLs didn't cause any real problems.

Split ttl into ttl.relative and ttl.absolute, and make sure the values are sane. Then correct all callers, and simplify out the time() calls where possible to make switching to PhabricatorTime easier.

Test Plan
  • Generated an SSH keypair.
  • Viewed a changeset.
  • Viewed a raw diff.
  • Viewed a commit's file data.
  • Viewed a temporary file's details, saw expiration date and relative time.
  • Ran unit tests.
  • (Didn't really test Phragment.)

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 4 2017, 7:28 PM
epriestley updated this revision to Diff 42366.Apr 4 2017, 7:37 PM
  • Recognize profile key in parameter dictionary.
epriestley updated this revision to Diff 42367.Apr 4 2017, 7:40 PM
  • Also recognize format key in parameter dictionary.
epriestley updated this revision to Diff 42368.Apr 4 2017, 7:43 PM
  • Also allow format to accept objects.
chad accepted this revision.Apr 4 2017, 9:28 PM

fml

This revision is now accepted and ready to land.Apr 4 2017, 9:28 PM
This revision was automatically updated to reflect the committed changes.