Page MenuHomePhabricator

Make the Files "TTL" API more structured

Authored by epriestley on Apr 4 2017, 7:28 PM.
Referenced Files
Unknown Object (File)
Tue, Mar 28, 11:24 PM
Unknown Object (File)
Thu, Mar 23, 8:00 PM
Unknown Object (File)
Wed, Mar 15, 7:45 AM
Unknown Object (File)
Wed, Mar 8, 5:58 PM
Unknown Object (File)
Fri, Mar 3, 5:57 AM
Unknown Object (File)
Feb 17 2023, 5:52 AM
Unknown Object (File)
Feb 16 2023, 1:34 PM
Unknown Object (File)
Feb 10 2023, 9:17 AM



Ref T11357. When creating a file, callers can currently specify a ttl. However, it isn't unambiguous what you're supposed to pass, and some callers get it wrong.

For example, to mean "this file expires in 60 minutes", you might pass either of these:

  • time() + phutil_units('60 minutes in seconds')
  • phutil_units('60 minutes in seconds')

The former means "60 minutes from now". The latter means "1 AM, January 1, 1970". In practice, because the GC normally runs only once every four hours (at least, until recently), and all the bad TTLs are cases where files are normally accessed immediately, these 1970 TTLs didn't cause any real problems.

Split ttl into ttl.relative and ttl.absolute, and make sure the values are sane. Then correct all callers, and simplify out the time() calls where possible to make switching to PhabricatorTime easier.

Test Plan
  • Generated an SSH keypair.
  • Viewed a changeset.
  • Viewed a raw diff.
  • Viewed a commit's file data.
  • Viewed a temporary file's details, saw expiration date and relative time.
  • Ran unit tests.
  • (Didn't really test Phragment.)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

  • Recognize profile key in parameter dictionary.
  • Also recognize format key in parameter dictionary.
  • Also allow format to accept objects.
This revision is now accepted and ready to land.Apr 4 2017, 9:28 PM
This revision was automatically updated to reflect the committed changes.