Page MenuHomePhabricator
Differential D17651

Correct two parameter strictness issues with file uploads
ClosedPublic
Actions

Authored by epriestley on Apr 10 2017, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 4:09 PM
Unknown Object (File)
Fri, Dec 13, 3:42 PM
Unknown Object (File)
Wed, Dec 11, 3:21 PM
Unknown Object (File)
Mon, Dec 9, 3:47 AM
Unknown Object (File)
Sun, Dec 8, 3:07 AM
Unknown Object (File)
Wed, Dec 4, 6:18 PM
Unknown Object (File)
Sat, Nov 30, 6:15 PM
Unknown Object (File)
Fri, Nov 29, 1:02 PM
View All Files
Subscribers
joshuaspence

Details

Reviewers
chad
Maniphest Tasks
T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0
Commits
rP944f7da48670: (stable) Correct two parameter strictness issues with file uploads
rPa7a068f84cd0: Correct two parameter strictness issues with file uploads
Summary

Fixes T12531. Strictness fallout from adding typechecking in D17616.

  • chunkedHash is not a real parameter, so the new typechecking was unhappy about it.
  • mime-type no longer allows null.
Test Plan
  • Ran arc upload --conduit-uri ... 12MB.zero on a 12MB file full of zeroes.
  • Before patch: badness, failure, fallback to one-shot uploads.
  • After patch: success and glory.

Diff Detail

Repository
rP Phabricator
Branch
files1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16380
Build 21788: Run Core Tests
Build 21787: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 10 2017, 10:49 PM
Harbormaster completed remote builds in B16379: Diff 42450.Apr 10 2017, 10:50 PM
epriestley mentioned this in T12531: Unable to upload file: failed to read 4583864320 bytes after offset 0.Apr 10 2017, 10:58 PM
joshuaspence added a subscriber: joshuaspence.Apr 10 2017, 10:58 PM
joshuaspence added inline comments.
src/applications/files/conduit/FileUploadChunkConduitAPIMethod.php
70

Is this meant to be $params['mime-type']? Otherwise it looks like $mime_type is unused.

epriestley planned changes to this revision.Apr 10 2017, 10:59 PM

uhhh yes

joshuaspence accepted this revision.Apr 10 2017, 11:00 PM
epriestley updated this revision to Diff 42451.Apr 10 2017, 11:00 PM
epriestley removed a reviewer: joshuaspence.
  • Actually set 'mime-type'.
Closed by commit rPa7a068f84cd0: Correct two parameter strictness issues with file uploads (authored by epriestley, committed by epriestley). · Explain WhyApr 10 2017, 11:01 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B16380: Diff 42451.Apr 10 2017, 11:01 PM
chad edited edge metadata.Apr 11 2017, 12:02 AM

I assume @joshuaspence should show up here?

pasted_file (300×590 px, 37 KB)

epriestley added a comment.Apr 11 2017, 12:11 AM

I removed him accidentally by racing arc diff against his accept. T12109 is a rough description.

epriestley added a comment.Apr 11 2017, 12:12 AM

That is, he got removed here, when an arc diff with Reviewers: chad in the message took effect:

Screen Shot 2017-04-10 at 5.11.01 PM.png (80×450 px, 20 KB)

chad added a comment.Apr 11 2017, 12:12 AM

oic

joshuaspence added a comment.Apr 11 2017, 12:13 AM

How could you??

frowncat

epriestley added a comment.Apr 11 2017, 12:13 AM

sorry T.T 😿

Revision Contents
Changeset List

PathSize
src/
applications/
files/
conduit/
15 lines
storage/
5 lines

Diff 42451

View Options

src/applications/files/conduit/FileUploadChunkConduitAPIMethod.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility