Page MenuHomePhabricator
Differential D17181

Allow auditors to be added and removed from commits in a modern way
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:50 PM
Unknown Object (File)
Tue, Dec 17, 11:46 PM
Unknown Object (File)
Tue, Dec 17, 11:46 PM
Unknown Object (File)
Tue, Dec 17, 11:46 PM
Unknown Object (File)
Tue, Dec 17, 11:33 PM
Unknown Object (File)
Thu, Dec 12, 7:31 AM
Unknown Object (File)
Mon, Dec 9, 4:49 AM
Unknown Object (File)
Mon, Dec 9, 1:10 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7676: Packages that are configured to auto-audit often generate audits that are un-closable
T10978: Modernize Audit
Commits
rP255e3fb1e4bf: Allow auditors to be added and removed from commits in a modern way
Summary

Ref T10978. Ref T7676. Make auditors work more like reviewers, so they can be freely added or removed.

Test Plan
  • Interacted with auditors via "Edit Commit" and API.
  • Comment area is still oldschool and doesn't work yet.

Diff Detail

Repository
rP Phabricator
Branch
commit5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15204
Build 19981: Run Core Tests
Build 19980: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
audit/
storage/
6 lines
diffusion/
editor/
19 lines
xaction/
231 lines
4 lines
repository/
storage/
5 lines

Diff 41317

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionCommitEditEngine.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitAuditorsTransaction.php

Loading...
View Options

src/applications/diffusion/xaction/DiffusionCommitTransactionType.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
Phabricator · Built by Phacility