Render more info for binary files in Differential
ClosedPublic
Actions

Authored by avivey on May 1 2016, 3:47 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10856: Small Revision page enhanchments

Commits

rPe1119b3f315b: Render more info for binary files in Differential

Summary

Ref T10856. The rendering logic was already there, but it was expecting the information under properties
field, whereas arc puts it under metadata. Not sure if that something that changed a long time ago or if
it was always like this.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 38131.May 1 2016, 3:47 AM

avivey retitled this revision from to render more info for binary files.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a reviewer: Blessed Reviewers.

avivey added a task: T10856: Small Revision page enhanchments.

Herald edited edge metadata. · View Herald TranscriptMay 1 2016, 3:47 AM

Herald added a subscriber: epriestley. · View Herald Transcript

avivey edited the test plan for this revision. (Show Details)May 1 2016, 3:53 AM

avivey edited edge metadata.

avivey added a reviewer: epriestley.Jun 1 2016, 5:48 PM

chad retitled this revision from render more info for binary files to Render more info for binary files in Differential.Jun 1 2016, 6:00 PM

epriestley accepted this revision.Jun 5 2016, 10:16 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/differential/render/DifferentialChangesetRenderer.php
641	Maybe `null` is better to show than `0 B` when the data is not present? There's a minor technical difference between an empty file (0 bytes long) and a file which does not exist. ` $size = idx(...); if ($size !== null) { $size = phutil_format_bytes(...); }