Ref T10856. The rendering logic was already there, but it was expecting the information under properties
field, whereas arc puts it under metadata. Not sure if that something that changed a long time ago or if
it was always like this.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T10856: Small Revision page enhanchments
- Commits
- rPe1119b3f315b: Render more info for binary files in Differential
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- arcpatch-D15828
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 12510 Build 15863: Run Core Tests Build 15862: arc lint + arc unit
Event Timeline
| src/applications/differential/render/DifferentialChangesetRenderer.php | ||
|---|---|---|
| 641 | Maybe null is better to show than 0 B when the data is not present? There's a minor technical difference between an empty file (0 bytes long) and a file which does not exist. `
$size = idx(...);
if ($size !== null) {
$size = phutil_format_bytes(...);
} | |
Comment Actions
arc currently uploads "size: 0" for un-existing files (https://secure.phabricator.com/diffusion/ARC/browse/master/src/workflow/ArcanistDiffWorkflow.php;19608cffe6d00e7ff21f96eb84e6ee1cf883d54b$2595-2604), but it probably shouldn't... I'll diff that as well :)