Paths

Table of Contentst

Differential D14624

Add case-insensitive array
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 7:55 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU65b877383e0e: Add case-insensitive array

Summary

This class is case-insensitive but also case-preserving. The primary motivation for this class is to assist in handling PHP classes, functions and interfaces (which are case-insensitive).

Test Plan

Added test cases.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9202
Build 10888: Run Core Tests
Build 10887: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35382.Dec 1 2015, 7:55 PM

joshuaspence retitled this revision from to Add case-insensitive array.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 7:55 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Add a getKeys() method

joshuaspence added a child revision: D14625: Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`.Dec 1 2015, 8:03 PM

epriestley accepted this revision.Dec 1 2015, 10:46 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/utils/CaseInsensitiveArray.php
119	Prefer `phutil_utf8_strtolower()` probably?

This revision is now accepted and ready to land.Dec 1 2015, 10:46 PM

Use phutil_utf8_strtolower instead of strtolower

Closed by commit rPHU65b877383e0e: Add case-insensitive array (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 4:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

utils/

CaseInsensitiveArray.php

121 lines

__tests__/

CaseInsensitiveArrayTestCase.php

109 lines

Diff 35391

View Options

src/__phutil_library_map__.php

View Options

src/utils/CaseInsensitiveArray.php

View Options

src/utils/tests/CaseInsensitiveArrayTestCase.php

Add case-insensitive arrayClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35391

src/__phutil_library_map__.php

src/utils/CaseInsensitiveArray.php

src/utils/__tests__/CaseInsensitiveArrayTestCase.php

Add case-insensitive array
ClosedPublic
Actions

Revision Contents
Changeset List

src/utils/tests/CaseInsensitiveArrayTestCase.php