Page MenuHomePhabricator
Differential D14624

Add case-insensitive array
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 7:55 PM.
Tags
None
Referenced Files
F13208256: D14624.id35391.diff
Thu, May 16, 12:18 PM
F13201885: D14624.diff
Tue, May 14, 5:51 PM
F13201769: D14624.id35391.diff
Tue, May 14, 3:54 PM
F13191437: D14624.id35398.diff
Sat, May 11, 9:02 PM
F13191436: D14624.id.diff
Sat, May 11, 9:02 PM
F13191429: D14624.id35382.diff
Sat, May 11, 8:57 PM
F13191428: D14624.id35383.diff
Sat, May 11, 8:57 PM
F13191423: D14624.id35391.diff
Sat, May 11, 8:52 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU65b877383e0e: Add case-insensitive array
Summary

This class is case-insensitive but also case-preserving. The primary motivation for this class is to assist in handling PHP classes, functions and interfaces (which are case-insensitive).

Test Plan

Added test cases.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9192
Build 10871: Run Core Tests
Build 10870: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35382.Dec 1 2015, 7:55 PM
joshuaspence retitled this revision from to Add case-insensitive array.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 7:55 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 35383.Dec 1 2015, 8:00 PM
joshuaspence edited edge metadata.

Add a getKeys() method

joshuaspence added a child revision: D14625: Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`.Dec 1 2015, 8:03 PM
epriestley accepted this revision.Dec 1 2015, 10:46 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/utils/CaseInsensitiveArray.php
119

Prefer phutil_utf8_strtolower() probably?

This revision is now accepted and ready to land.Dec 1 2015, 10:46 PM
joshuaspence updated this revision to Diff 35391.Dec 2 2015, 3:13 AM
joshuaspence edited edge metadata.

Use phutil_utf8_strtolower instead of strtolower

Closed by commit rPHU65b877383e0e: Add case-insensitive array (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 4:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35382

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/utils/CaseInsensitiveArray.php

Loading...
View Options

src/utils/__tests__/CaseInsensitiveArrayTestCase.php

Loading...
Phabricator · Built by Phacility