Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 8:03 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC8ed3c45c8226: Use `CaseInsensitiveArray` in…

Summary

Demonstrates the use of CaseInsensitiveArray. Depends on D14624.

Test Plan

Ran unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35384.Dec 1 2015, 8:03 PM

joshuaspence retitled this revision from to Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D14624: Add case-insensitive array.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 8:03 PM

Herald added a subscriber: Korvin. · View Herald Transcript

One of the unit tests looks very related, maybe just a libphutil version issue though?

This revision is now accepted and ready to land.Dec 2 2015, 3:20 AM

Closed by commit rARC8ed3c45c8226: Use `CaseInsensitiveArray` in… (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 9:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

22 lines

Diff 35420

View Options

src/lint/linter/xhpast/rules/ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule.php

Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`ClosedPublicActions