Page MenuHomePhabricator
Differential D14624

Add case-insensitive array
ClosedPublic
Actions

Authored by joshuaspence on Dec 1 2015, 7:55 PM.
Tags
None
Referenced Files
F14827157: D14624.diff
Wed, Jan 29, 4:11 AM
Unknown Object (File)
Mon, Jan 27, 6:33 AM
Unknown Object (File)
Fri, Jan 24, 6:24 PM
Unknown Object (File)
Fri, Jan 24, 10:11 AM
Unknown Object (File)
Fri, Jan 24, 10:11 AM
Unknown Object (File)
Fri, Jan 24, 10:11 AM
Unknown Object (File)
Fri, Jan 24, 10:11 AM
Unknown Object (File)
Fri, Jan 24, 10:11 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU65b877383e0e: Add case-insensitive array
Summary

This class is case-insensitive but also case-preserving. The primary motivation for this class is to assist in handling PHP classes, functions and interfaces (which are case-insensitive).

Test Plan

Added test cases.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9193
Build 10873: Run Core Tests
Build 10872: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 35382.Dec 1 2015, 7:55 PM
joshuaspence retitled this revision from to Add case-insensitive array.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 1 2015, 7:55 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 35383.Dec 1 2015, 8:00 PM
joshuaspence edited edge metadata.

Add a getKeys() method

joshuaspence added a child revision: D14625: Use `CaseInsensitiveArray` in `ArcanistFunctionCallShouldBeTypeCastXHPASTLinterRule`.Dec 1 2015, 8:03 PM
epriestley accepted this revision.Dec 1 2015, 10:46 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/utils/CaseInsensitiveArray.php
118

Prefer phutil_utf8_strtolower() probably?

This revision is now accepted and ready to land.Dec 1 2015, 10:46 PM
joshuaspence updated this revision to Diff 35391.Dec 2 2015, 3:13 AM
joshuaspence edited edge metadata.

Use phutil_utf8_strtolower instead of strtolower

Closed by commit rPHU65b877383e0e: Add case-insensitive array (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 2 2015, 4:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35383

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/utils/CaseInsensitiveArray.php

Loading...
View Options

src/utils/__tests__/CaseInsensitiveArrayTestCase.php

Loading...
Phabricator · Built by Phacility