Page MenuHomePhabricator

Prevent double rendering of unit test results
ClosedPublic

Authored by joshuaspence on Nov 16 2015, 7:48 PM.
Tags
None
Referenced Files
F17921973: D14495.diff
Wed, Jul 30, 6:07 AM
F17729155: D14495.diff
Sat, Jul 19, 6:06 PM
F17685421: D14495.id.diff
Mon, Jul 14, 3:17 AM
Unknown Object (File)
Jun 16 2025, 4:01 AM
Unknown Object (File)
May 30 2025, 3:52 PM
Unknown Object (File)
May 29 2025, 9:42 PM
Unknown Object (File)
May 29 2025, 8:02 PM
Unknown Object (File)
May 28 2025, 8:17 AM

Details

Summary

D14037 had the logic slightly wrong and unit test results are now being double rendered.

Test Plan

Ran a unit test with arc unit -- path/to/test and saw the results rendered only once.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8878
Build 10387: Run Core Tests
Build 10386: arc lint + arc unit

Event Timeline

joshuaspence retitled this revision from to Prevent double rendering of unit test results.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Maybe add a comment explaining why !$thing causes $thing to occur.

This revision is now accepted and ready to land.Nov 16 2015, 8:52 PM
This revision was automatically updated to reflect the committed changes.

@epriestley's comment shows why shouldEchoTestResults is a bad name for this method. A name like testEngineWillEchoTestResults is also awful, but it better communicates the purpose. The problem is that there is no subject in the name. It would be clearer if the method were rendererShouldEchoTestResults and the logic were inverted.