Ref T8726. Herald actions are technically sort-of modular already, but make them more aggressively modular similar to HeraldField.
I plan to obsolete and replace HeraldCustomAction.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T8726: Modularize Herald fields and actions
- Commits
- Restricted Diffusion Commit
rP56dd5211f0d0: Make Herald action modularization more aggressive
Saw actions in nice groups; created and ran a "Do Nothing" action. Transcripts are a bit rough for now.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- heraldx2
- Lint
Lint Passed Severity Location Code Message Advice src/applications/herald/controller/HeraldTranscriptController.php:358 XHP16 TODO Comment Advice src/applications/herald/controller/HeraldTranscriptController.php:391 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 7302 Build 7644: [Placeholder Plan] Wait for 30 Seconds Build 7643: arc lint + arc unit
Event Timeline
Comment Actions
Should be moot since it's cached behind PhutilClassMapQuery for the specific concern there.