Page MenuHomePhabricator

Make Herald action modularization more aggressive
ClosedPublic

Authored by epriestley on Jul 17 2015, 5:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 6:40 AM
Unknown Object (File)
Sun, Mar 3, 7:26 PM
Unknown Object (File)
Thu, Feb 29, 11:26 PM
Unknown Object (File)
Feb 21 2024, 5:06 AM
Unknown Object (File)
Feb 18 2024, 11:55 AM
Unknown Object (File)
Feb 11 2024, 1:08 PM
Unknown Object (File)
Feb 9 2024, 10:23 AM
Unknown Object (File)
Feb 8 2024, 3:55 PM

Details

Summary

Ref T8726. Herald actions are technically sort-of modular already, but make them more aggressively modular similar to HeraldField.

I plan to obsolete and replace HeraldCustomAction.

Test Plan

Saw actions in nice groups; created and ran a "Do Nothing" action. Transcripts are a bit rough for now.

Event Timeline

epriestley retitled this revision from to Make Herald action modularization more aggressive.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
joshuaspence added inline comments.
src/applications/herald/action/HeraldAction.php
69

I wonder if we can do this in a more general way, see D13541 for am example of why.

Should be moot since it's cached behind PhutilClassMapQuery for the specific concern there.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 20 2015, 6:15 PM
This revision was automatically updated to reflect the committed changes.