Optimize ArcanistXHPASTLinterRule::getLintID.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARCbbccf1dd4059: Linter performance optimization
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
For consistency, prefer lintID.
It looks like getLintSeverity in the parent is also maybe cacheable? It's building a map every time and mpull'ing it? Caching that might make this moot.
Comment Actions
Cache ArcanistXHPASTLinter::getLintNameMap and ArcanistXHPASTLinter::getLintSeverityMap