Paths

Table of Contentst

Differential D13377

Render lint results as Harbormaster lint messages
ClosedPublic
Actions

Authored by epriestley on Jun 21 2015, 5:14 PM.

Tags

None

Referenced Files

	F15437952: D13377.id32455.diff
	Tue, Mar 25, 10:19 PM

	F15431989: D13377.id32455.diff
	Mon, Mar 24, 3:43 PM

	F15427384: D13377.id32389.diff
	Sun, Mar 23, 2:07 PM

	F15427176: D13377.id32389.diff
	Sun, Mar 23, 1:13 PM

	F15426501: D13377.id.diff
	Sun, Mar 23, 9:09 AM

	F15422236: D13377.diff
	Sat, Mar 22, 6:48 AM

	F15333699: D13377.id32389.diff
	Sat, Mar 8, 4:06 AM

	F15285149: D13377.diff
	Tue, Mar 4, 11:45 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T8095: Let Harbormaster own Lint and Unit results

Commits

Restricted Diffusion Commit
rPe618b672d233: Render lint results as Harbormaster lint messages

Summary

Ref T8095. Render lint results in a future-ready way.

This makes the renderer accept HarbormasterBuildLintMessage objects. If we have legacy data instead, it converts it into HarbormasterBuildLintMessage objects.

Design is a bit rough but will be cleaned up later after T7739.

This moves away from "postponed linters", which are obsolete after Harbormaster (and were only ever used by Facebook).

Test Plan

Screen Shot 2015-06-21 at 10.09.34 AM.png (291×1 px, 61 KB)

Diff Detail

Repository

Branch

unit1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/customfield/DifferentialLintField.php:57	XHP16	TODO Comment
Advice	src/applications/differential/customfield/DifferentialLintField.php:87	XHP16	TODO Comment
Advice	src/applications/differential/customfield/DifferentialLintField.php:162	XHP16	TODO Comment
Advice	src/applications/harbormaster/view/HarbormasterLintPropertyView.php:73	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 6918
Build 6940: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 32389.Jun 21 2015, 5:14 PM

epriestley retitled this revision from to Render lint results as Harbormaster lint messages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8095: Let Harbormaster own Lint and Unit results.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 21 2015, 5:14 PM

epriestley mentioned this in D13378: Render unit results as Harbormaster unit messages.Jun 21 2015, 5:39 PM

btrahan accepted this revision.Jun 22 2015, 4:59 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2015, 4:59 PM

epriestley mentioned this in T8089: Unprototype Harbormaster (v1).Jun 22 2015, 9:21 PM

Closed by commit rPe618b672d233: Render lint results as Harbormaster lint messages (authored by epriestley, committed by epriestley). · Explain WhyJun 23 2015, 5:24 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPb72deb332ca7: Render unit results as Harbormaster unit messages.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

customfield/

DifferentialLintField.php

265 lines

harbormaster/

view/

HarbormasterLintPropertyView.php

78 lines

view/

phui/

PHUIStatusItemView.php

1 line

Diff 32389

src/__phutil_library_map__.php

Loading...

src/applications/differential/customfield/DifferentialLintField.php

Loading...

src/applications/harbormaster/view/HarbormasterLintPropertyView.php

Loading...

src/view/phui/PHUIStatusItemView.php

Loading...