Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 7:21 AM.

Details

Reviewers

epriestley
avivey

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7977: Associate Symbols with Repositories directly (Instead of arc projects)

Commits

rARC753705b2c5b5: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase

Summary

Ref T7977. The ArcanistTestCase class is pointless and can be replaced by ArcanistPhutilTestCase. Furthermore, it sorta makes sense to just rename ArcanistPhutilTestCase to PhutilTestCase. Depends on D12664 and D12666.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 5690
Build 5709: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30426.May 3 2015, 7:21 AM

joshuaspence retitled this revision from to Remove ArcanistTestCase class.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7977: Associate Symbols with Repositories directly (Instead of arc projects).

joshuaspence added a parent revision: D12664: Improve getLink method for unit tests.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 7:22 AM

Herald added subscribers: epriestley, Korvin, aurelijus. · View Herald Transcript

Rename ArcanistPhutilTestCase to PhutilTestCase

joshuaspence updated this object.May 7 2015, 11:03 AM

joshuaspence updated this object.

joshuaspence added a parent revision: D12666: Remove PhutilTestCase class.

Rebase

avivey retitled this revision from Remove ArcanistTestCase class to Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase.May 19 2015, 2:05 AM

avivey added a child revision: D12667: Replace ArcanistPhutilTestCase refs with PhutilTestCase.

avivey accepted this revision.May 19 2015, 2:15 AM

avivey added a reviewer: avivey.

joshuaspence mentioned this in D12666: Remove PhutilTestCase class.May 19 2015, 1:16 PM

epriestley accepted this revision.May 19 2015, 2:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 2:10 PM

Closed by commit rARC753705b2c5b5: Rename ArcanistPhutilTestCase to PhutilTestCase and Remove ArcanistTestCase (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 11:42 PM

This revision was automatically updated to reflect the committed changes.

jhurwitz mentioned this in T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.Aug 16 2016, 2:37 AM