Page MenuHomePhabricator
Differential D12458

Implement a projects() datasource function
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 4:16 PM.
Tags
None
Referenced Files
F18867534: D12458.id29901.diff
Tue, Nov 4, 12:59 AM
F18764351: D12458.diff
Tue, Oct 7, 5:34 AM
F18761190: D12458.id.diff
Mon, Oct 6, 12:49 PM
F18756036: D12458.diff
Sun, Oct 5, 8:51 AM
F18740599: D12458.id29954.diff
Oct 2 2025, 4:08 AM
F18649907: D12458.id.diff
Sep 20 2025, 10:38 PM
F18625536: D12458.diff
Sep 15 2025, 10:59 PM
F18622977: D12458.diff
Sep 15 2025, 1:45 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPc246aa26382a: Implement a projects() datasource function
Summary

Ref T4100. This is like members(), but is implemented on top of the raw datasource. This is a lot simpler and involves way less code duplication.

I'll go back and implement members() like this, too.

Nothing actually uses this yet.

Test Plan
  • Used browse view to browse datasource.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29901.Apr 18 2015, 4:16 PM
epriestley retitled this revision from to Implement a projects() datasource function.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 4:16 PM
epriestley added inline comments.Apr 18 2015, 6:09 PM
src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php
42–62

This isn't quite right, but a diff a few changes from now (probably D12462 by the time you read this) adjusts this source anyway.

btrahan accepted this revision.Apr 20 2015, 4:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:28 PM
Closed by commit rPc246aa26382a: Implement a projects() datasource function (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29954

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php

Loading...
Phabricator · Built by Phacility