Page MenuHomePhabricator
Differential D12458

Implement a projects() datasource function
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 7:19 AM
Unknown Object (File)
Sat, Jan 25, 11:55 AM
Unknown Object (File)
Fri, Jan 24, 2:48 AM
Unknown Object (File)
Fri, Jan 24, 2:48 AM
Unknown Object (File)
Fri, Jan 24, 2:48 AM
Unknown Object (File)
Tue, Jan 21, 3:17 PM
Unknown Object (File)
Sat, Jan 18, 5:28 AM
Unknown Object (File)
Sun, Jan 5, 5:20 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rPc246aa26382a: Implement a projects() datasource function
Summary

Ref T4100. This is like members(), but is implemented on top of the raw datasource. This is a lot simpler and involves way less code duplication.

I'll go back and implement members() like this, too.

Nothing actually uses this yet.

Test Plan
  • Used browse view to browse datasource.

Diff Detail

Repository
rP Phabricator
Branch
logic6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5368
Build 5386: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29901.Apr 18 2015, 4:16 PM
epriestley retitled this revision from to Implement a projects() datasource function.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 4:16 PM
epriestley added inline comments.Apr 18 2015, 6:09 PM
src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php
41–61

This isn't quite right, but a diff a few changes from now (probably D12462 by the time you read this) adjusts this source anyway.

btrahan accepted this revision.Apr 20 2015, 4:28 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:28 PM
Closed by commit rPc246aa26382a: Implement a projects() datasource function (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29901

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorUserProjectsDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadCompositeDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/applications/typeahead/view/PhabricatorTypeaheadTokenView.php

Loading...
Phabricator · Built by Phacility