Paths

Table of Contentst

Differential D12419

Add a linter rule for useless overriding methods
ClosedPublic
Actions

Authored by joshuaspence on Apr 15 2015, 10:37 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 25, 2:35 PM

	Unknown Object (File)
	Dec 2 2024, 11:50 AM

	Unknown Object (File)
	Nov 27 2024, 7:01 PM

	Unknown Object (File)
	Nov 26 2024, 9:38 PM

	Unknown Object (File)
	Nov 8 2024, 9:00 PM

	Unknown Object (File)
	Nov 8 2024, 5:50 PM

	Unknown Object (File)
	Nov 2 2024, 7:54 AM

	Unknown Object (File)
	Oct 30 2024, 6:43 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7415: Write a linter rule to detect when a class name is used instead of self
T7409: Implement PHPCS lints

Commits

rARC6295134bc7fb: Add a linter rule for useless overriding methods

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_USELESS_OVERRIDING_METHOD for detecting method which only call their parent method. Based on Generic_Sniffs_CodeAnalysis_UselessOverridingMethodSniff.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5438
Build 5456: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,331 ms	ArcanistPuppetLintLinterTestCase::testLinter
	732 ms	ArcanistCSSLintLinterTestCase::testLinter
	146 ms	ArcanistCSSLintLinterTestCase::testVersion
	162 ms	ArcanistChmodLinterTestCase::testLinter
	275 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29827.Apr 15 2015, 10:37 AM

joshuaspence retitled this revision from to Add a linter rule for useless overriding methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2015, 10:37 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 15 2015, 11:49 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2015, 11:49 AM

Rebase

joshuaspence updated this object.May 7 2015, 10:23 AM

Closed by commit rARC6295134bc7fb: Add a linter rule for useless overriding methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 11:08 AM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D12828: Improve linter rule for useless overriding methods.May 13 2015, 9:05 PM

joshuaspence added a task: T7415: Write a linter rule to detect when a class name is used instead of self.May 13 2015, 9:38 PM

joshuaspence mentioned this in T7415: Write a linter rule to detect when a class name is used instead of self.

joshuaspence mentioned this in rARCe1a051a033b8: Improve linter rule for useless overriding methods.May 14 2015, 9:10 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

87 lines

__tests__/

xhpast/

useless-overriding-method.lint-test

19 lines

Diff 30024

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/useless-overriding-method.lint-test

Loading...