Paths

Table of Contentst

Differential D12828

Improve linter rule for useless overriding methods
ClosedPublic
Actions

Authored by joshuaspence on May 13 2015, 9:05 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCe1a051a033b8: Improve linter rule for useless overriding methods

Summary

Ref T7409. This linter rule was added in D12419, but fails in some specific cases. Improve the handling of n_DECLARATION_PARAMETER_LIST.

Test Plan

Added unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30843.May 13 2015, 9:05 PM

joshuaspence retitled this revision from to Improve linter rule for useless overriding methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 13 2015, 9:05 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 14 2015, 1:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 14 2015, 1:07 PM

Closed by commit rARCe1a051a033b8: Improve linter rule for useless overriding methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 14 2015, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

10 lines

__tests__/

xhpast/

useless-overriding-method.lint-test

5 lines

Diff 30907

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/useless-overriding-method.lint-test

Improve linter rule for useless overriding methodsClosedPublicActions