Page MenuHomePhabricator
Differential D12419

Add a linter rule for useless overriding methods
ClosedPublic
Actions

Authored by joshuaspence on Apr 15 2015, 10:37 AM.
Tags
None
Referenced Files
F14775164: D12419.id30817.diff
Fri, Jan 24, 2:39 AM
F14775163: D12419.id30024.diff
Fri, Jan 24, 2:39 AM
F14775162: D12419.id29827.diff
Fri, Jan 24, 2:39 AM
F14775161: D12419.id.diff
Fri, Jan 24, 2:39 AM
F14775160: D12419.diff
Fri, Jan 24, 2:38 AM
Unknown Object (File)
Wed, Jan 22, 12:04 AM
Unknown Object (File)
Tue, Jan 21, 7:03 PM
Unknown Object (File)
Tue, Jan 21, 3:42 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7415: Write a linter rule to detect when a class name is used instead of self
T7409: Implement PHPCS lints
Commits
rARC6295134bc7fb: Add a linter rule for useless overriding methods
Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_USELESS_OVERRIDING_METHOD for detecting method which only call their parent method. Based on Generic_Sniffs_CodeAnalysis_UselessOverridingMethodSniff.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5319
Build 5337: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29827.Apr 15 2015, 10:37 AM
joshuaspence retitled this revision from to Add a linter rule for useless overriding methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7409: Implement PHPCS lints.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2015, 10:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 15 2015, 11:49 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 11:49 AM
joshuaspence updated this revision to Diff 30024.Apr 22 2015, 12:17 PM
joshuaspence edited edge metadata.

Rebase

joshuaspence updated this object.May 7 2015, 10:23 AM
Closed by commit rARC6295134bc7fb: Add a linter rule for useless overriding methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 13 2015, 11:08 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D12828: Improve linter rule for useless overriding methods.May 13 2015, 9:05 PM
joshuaspence added a task: T7415: Write a linter rule to detect when a class name is used instead of self.May 13 2015, 9:38 PM
joshuaspence mentioned this in T7415: Write a linter rule to detect when a class name is used instead of self.
joshuaspence mentioned this in rARCe1a051a033b8: Improve linter rule for useless overriding methods.May 14 2015, 9:10 PM

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
87 lines
__tests__/
xhpast/
19 lines

Diff 29827

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Loading...
View Options

src/lint/linter/__tests__/xhpast/useless-overriding-method.lint-test

Loading...
Phabricator · Built by Phacility