Add a linter rule for useless overriding methods
6295134bc7fb
Actions

Description

Add a linter rule for useless overriding methods

Summary: Ref T7409. Adds ArcanistXHPASTLinter::LINT_USELESS_OVERRIDING_METHOD for detecting method which only call their parent method. Based on Generic_Sniffs_CodeAnalysis_UselessOverridingMethodSniff.

Test Plan: Added unit tests.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7409

Differential Revision: https://secure.phabricator.com/D12419

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on May 13 2015, 11:08 AM

Reviewer

Blessed Reviewers

Differential Revision

D12419: Add a linter rule for useless overriding methods

Parents

rARCd2b38cdf9444: `pht` all the things

Branches

Unknown

Tags

Unknown

Tasks

T7415: Write a linter rule to detect when a class name is used instead of self
T7409: Implement PHPCS lints

Event Timeline

joshuaspence committed rARC6295134bc7fb: Add a linter rule for useless overriding methods (authored by joshuaspence).May 13 2015, 11:07 AM

joshuaspence added a task: T7409: Implement PHPCS lints.

joshuaspence added a task: T7415: Write a linter rule to detect when a class name is used instead of self.May 13 2015, 9:38 PM

Changes (2)

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

__tests__/

xhpast/

useless-overriding-method.lint-test

rARC6295134bc7fb

View Options

src/lint/linter/ArcanistXHPASTLinter.php