Page MenuHomePhabricator

Modernize Legalpad edge types
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 12:28 PM.
Tags
None
Referenced Files
F18616096: D11082.id.diff
Sun, Sep 14, 4:14 PM
F18601248: D11082.diff
Sat, Sep 13, 11:55 AM
F18504560: D11082.id.diff
Thu, Sep 4, 11:53 PM
F18495854: D11082.diff
Thu, Sep 4, 4:58 PM
F18287746: D11082.id26602.diff
Sat, Aug 23, 7:49 AM
F18048207: D11082.diff
Aug 3 2025, 1:25 PM
F17948726: D11082.id26657.diff
Jul 31 2025, 9:53 PM
F17896995: D11082.id26644.diff
Jul 29 2025, 7:15 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP83d1e3edb59b: Modernize Legalpad edge types
Summary

Modernize Legalpad edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan
  1. Created a Herald rule to require legal signatures on all diffs.
  2. Created a new diff.
  3. Saw the transaction string appear correctly.

I wasn't able to check the inverse transaction because there is none. Also, I couldn't see any text on the feed (presumably, transactions authored by Herald do not generate feed items)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Modernize Legalpad edge types.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.

Don't write inverse transactions

joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 4:03 PM
This revision was automatically updated to reflect the committed changes.