Page MenuHomePhabricator
Differential D11082

Modernize Legalpad edge types
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:28 PM.
Tags
None
Referenced Files
F13211850: D11082.diff
Fri, May 17, 6:09 AM
F13208462: D11082.diff
Thu, May 16, 3:41 PM
F13195517: D11082.diff
Sun, May 12, 10:27 PM
F13182235: D11082.id26657.diff
Thu, May 9, 9:31 PM
F13178271: D11082.diff
Wed, May 8, 8:18 PM
Unknown Object (File)
Thu, Apr 25, 1:49 AM
Unknown Object (File)
Mon, Apr 22, 3:26 AM
Unknown Object (File)
Apr 12 2024, 3:39 PM
View All Files
Subscribers
chad
epriestley
Krenair

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP83d1e3edb59b: Modernize Legalpad edge types
Summary

Modernize Legalpad edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan
  1. Created a Herald rule to require legal signatures on all diffs.
  2. Created a new diff.
  3. Saw the transaction string appear correctly.

I wasn't able to check the inverse transaction because there is none. Also, I couldn't see any text on the feed (presumably, transactions authored by Herald do not generate feed items)

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3412
Build 3419: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26602.Dec 30 2014, 12:28 PM
joshuaspence retitled this revision from to Modernize Legalpad edge types.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:28 PM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 26644.Dec 31 2014, 2:40 AM
joshuaspence edited edge metadata.

Don't write inverse transactions

joshuaspence updated this object.Dec 31 2014, 2:44 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
chad added a subscriber: chad.Dec 31 2014, 5:03 AM

ohmyglob

Krenair added a subscriber: Krenair.Dec 31 2014, 1:27 PM
epriestley accepted this revision.Dec 31 2014, 4:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2014, 4:03 PM
Closed by commit rP83d1e3edb59b: Modernize Legalpad edge types (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 1 2015, 12:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
differential/
customfield/
2 lines
editor/
2 lines
legalpad/
edge/
102 lines
12 lines
infrastructure/
edges/
constants/
10 lines
internationalization/
translation/
2 lines

Diff 26644

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/customfield/DifferentialRequiredSignaturesField.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/legalpad/edge/LegalpadObjectNeedsSignatureEdgeType.php

Loading...
View Options

src/applications/legalpad/edge/LegalpadSignatureNeededByObjectEdgeType.php

Loading...
View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility