Page MenuHomePhabricator

Allow audit email to generate from multiple transactions
ClosedPublic

Authored by epriestley on Jul 22 2014, 9:30 PM.
Tags
None
Referenced Files
F13143479: D10022.diff
Fri, May 3, 7:30 AM
F13140338: D10022.diff
Fri, May 3, 3:38 AM
Unknown Object (File)
Mon, Apr 29, 3:38 PM
Unknown Object (File)
Wed, Apr 24, 11:39 PM
Unknown Object (File)
Fri, Apr 19, 2:04 AM
Unknown Object (File)
Fri, Apr 19, 2:03 AM
Unknown Object (File)
Fri, Apr 19, 2:03 AM
Unknown Object (File)
Fri, Apr 19, 2:03 AM
Subscribers

Details

Summary

Ref T4896. Begins laying groundwork to split comments apart so they behave like transactions, ultimately enabling the migration.

Test Plan

Made several different types of comments, verified resulting email looks OK.

Diff Detail

Repository
rP Phabricator
Branch
audit6
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1845
Build 1846: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow audit email to generate from multiple transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
joshuaspence edited edge metadata.
joshuaspence added inline comments.
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
539

Is that any better/different to just if ($content) {?

This revision is now accepted and ready to land.Jul 23 2014, 1:48 PM
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
539

For posterity, D10020 has the reasoning -- the behavior differs on the string "0".

(There's a user on GitHub with this username (https://github.com/0) and he filed an issue a while ago that his username didn't work in Phabricator. This was fixed circa rP0e672e2.)

epriestley edited edge metadata.
  • Double-checking that lint is good.
epriestley updated this revision to Diff 24157.

Closed by commit rP970058927987 (authored by @epriestley).