2021 Week 10 (Early March)

Updated 1,146 Days AgoPublic

Actions

Summary of changes from February 26, 2021 to March 4, 2021.

• These changes were promoted to stable.

General

[] MySQL GET_LOCK(): See T13627. Fixed a correctness issue with MySQL GET_LOCK() behavior in versions of MySQL older than 5.7:

Before MySQL 5.7, only a single simultaneous lock can be acquired and GET_LOCK() releases any existing lock.
https://dev.mysql.com/doc/refman/5.7/en/locking-functions.html#function_get-lock

This behavior could cause writers in a multi-master cluster to release write locks during a write, if they needed to synchronize their working copy state first and had previously failed to acquire the write lock at least once. This converged to the repository failing safely into a "Write Interruption" state and refusing new writes. Either upgrading Phabricator or upgrading to MySQL 5.7 or newer is sufficient to avoid this.

If you are designing a locking API, please design it so that a method named GET_LOCK() does not ever release any locks at all.

Alt Text: See T13629. Files now support an "Alt Text" field, and images in most contexts will try to use the first of these sources of alt text:

• The explicit "alt" attribute in {F123, alt="example"}.
• The "Alt Text" on the File object.
• A low-quality, automatically generated default alt text like "duck.jpg (600x400 px, 75KB)" which may or may not be better than nothing.

(If you use alt text and have an opinion on the behavior of the automatic fallback alt text, including "throw it in the garbage", let me know and I'll likely just do whatever you tell me to with it.)

Security

• No notes in this period.

Migrations

• No migrations in this period.

Upgrading / Compatibility

• No notes in this period.

Minor

• [] arc land now uses a new mechanism to select an X..Y range of commits from history, intended to fix problems when X..Y includes merge commits. See T13576.
• Fixed an issue where arc could fail to create .git/arc/ before writing configuration there.
• Fixed an issue where paginating past the first page of notifications could fail if the last visible notification on the first page was delivered to multiple recipients. See T13623.
• [] Fixed an error that occurred when a commit tried to update a revision, but the commit's author couldn't see the revision or couldn't interact with the API. See T13625.
• [] Added a bin/user approve command to approve accounts from the CLI. See T13578.
• Differential now has an editable "Author" field, and authors have a new "Foist Upon" comment action which serves as an inverse to "Commandeer". This makes it easy to undo an accidental commandeering. See T13628.
• [] Diffusion now uses the same icon as Differential ("") to indicate that an auditor has resigned.
• Diffusion now considers "Repository Identities" when testing if a new auditor is invalid because they are a commit's author.

The [] icon indicates a change that supports a customer.
The [] icon indicates a contributed change.