Page MenuHomePhabricator
Differential D18436

Update Settings to use TwoColumn fixed layout
ClosedPublic
Actions

Authored by chad on Aug 17 2017, 3:13 AM.
Tags
None
Referenced Files
F18107498: D18436.id.diff
Mon, Aug 11, 1:05 AM
F18105633: D18436.id44297.diff
Sun, Aug 10, 6:57 PM
F18098566: D18436.id44296.diff
Fri, Aug 8, 9:13 PM
F18097435: D18436.diff
Fri, Aug 8, 1:19 PM
F18094894: D18436.diff
Thu, Aug 7, 10:24 PM
F18091239: D18436.id44297.diff
Wed, Aug 6, 8:29 PM
F17941387: D18436.id.diff
Thu, Jul 31, 5:22 AM
F17926241: D18436.diff
Wed, Jul 30, 12:50 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPdc10bb1f4980: Update Settings to use TwoColumn fixed layout
Summary

Simplifies the page, adds base support for PHUITwoColumn fixed from Instances (which I'll delete css there).

Test Plan

click on every settings page, UI seems in tact, check mobile, desktop, mobile menus.

image.png (2×2 px, 308 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
settings/
controller/
8 lines
panel/
2 lines
transactions/
editengine/
13 lines
webroot/
rsrc/
css/
phui/
51 lines

Diff 44297

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/controller/PhabricatorSettingsMainController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility