HomePhabricator

Fix transaction queries using withComments() for transactions with no comments

Description

Fix transaction queries using withComments() for transactions with no comments

Summary:
See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan:
Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18667

Details

Provenance
epriestleyAuthored on Oct 2 2017, 2:21 PM
epriestleyPushed on Oct 2 2017, 4:09 PM
Reviewer
amckinley
Differential Revision
D18667: Fix transaction queries using withComments() for transactions with no comments
Parents
rP5c73c169fd31: Rough cut of "Move tasks to column..."
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18599
Build 25053: Run Core Tests