Page MenuHomePhabricator

Fix transaction queries using withComments() for transactions with no comments
ClosedPublic

Authored by epriestley on Oct 2 2017, 2:24 PM.
Tags
None
Referenced Files
F19894742: D18667.id.diff
Sat, Mar 28, 4:46 PM
F19703350: D18667.diff
Feb 11 2026, 2:06 AM
F19703348: D18667.diff
Feb 11 2026, 2:06 AM
F19508841: D18667.id44819.diff
Jan 10 2026, 11:11 AM
F18841392: D18667.id44818.diff
Oct 28 2025, 8:45 AM
F18751663: D18667.id.diff
Oct 4 2025, 12:07 PM
F18618154: D18667.diff
Sep 14 2025, 11:19 PM
F18110082: D18667.id.diff
Aug 11 2025, 4:02 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan

Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable