Page MenuHomePhabricator

Fix transaction queries using withComments() for transactions with no comments
ClosedPublic

Authored by epriestley on Oct 2 2017, 2:24 PM.
Tags
None
Referenced Files
F15322101: D18667.diff
Thu, Mar 6, 11:31 PM
Unknown Object (File)
Mon, Feb 17, 11:25 AM
Unknown Object (File)
Wed, Feb 12, 2:55 AM
Unknown Object (File)
Feb 7 2025, 3:29 AM
Unknown Object (File)
Feb 4 2025, 10:37 AM
Unknown Object (File)
Jan 28 2025, 6:17 AM
Unknown Object (File)
Jan 25 2025, 6:33 PM
Unknown Object (File)
Jan 24 2025, 10:39 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/daemons-tasks-crashing-in-a-loop-during-reindex/506/1. Some object types (for example, Passphrase Credentials) support indexing but not commenting.

Make withComments(...) work properly if the transaction type does not support comments.

Test Plan

Indexed a credential (no comments) and a revision (comments) with bin/search index --trace ....

Before, credential fataled.

After, credetial succeeds, and skips the transaction query.

Before and after, the revision queries the transaction table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable