Paths

Table of Contentst

Differential D18715

Fix an issue with attempting to index comments on packages
ClosedPublic
Actions

Authored by epriestley on Oct 20 2017, 2:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 22, 12:41 AM

	Unknown Object (File)
	Sat, Dec 7, 3:56 PM

	Unknown Object (File)
	Fri, Dec 6, 9:09 AM

	Unknown Object (File)
	Mon, Dec 2, 12:41 PM

	Unknown Object (File)
	Fri, Nov 29, 12:52 AM

	Unknown Object (File)
	Mon, Nov 25, 1:26 AM

	Unknown Object (File)
	Nov 8 2024, 8:52 PM

	Unknown Object (File)
	Nov 8 2024, 7:20 PM

View All 84 Files

Subscribers

None

Details

Reviewers

Commits

rP01b1854fb45c: Fix an issue with attempting to index comments on packages

Summary

See rPcd14194a329788d5fff6365bcade278fd18f3612 for a similar change. Implement getApplicationTransactionCommentObject() to return null explicitly.

Test Plan

Ran bin/search index --type ownerspackage, got indexing after change.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 20 2017, 2:41 PM

Harbormaster completed remote builds in B18705: Diff 44927.Oct 20 2017, 2:42 PM

amckinley accepted this revision.Oct 20 2017, 4:03 PM

This revision is now accepted and ready to land.Oct 20 2017, 4:03 PM

Closed by commit rP01b1854fb45c: Fix an issue with attempting to index comments on packages (authored by epriestley). · Explain WhyOct 20 2017, 4:38 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18729: Fix a couple of other missing getApplicationTransactionCommentObject() implementations.Oct 24 2017, 12:59 PM

epriestley mentioned this in rP28a24c333fdd: Fix a couple of other missing getApplicationTransactionCommentObject()….Oct 24 2017, 4:05 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

storage/

PhabricatorOwnersPackageTransaction.php

4 lines

Diff 44931

src/applications/owners/storage/PhabricatorOwnersPackageTransaction.php

Loading...