Paths

Table of Contentst

Diffusion libphutil ddc0e031461b

When including files, also print E_COMPILE_ERROR to avoid dying silently
ddc0e031461b
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

When including files, also print E_COMPILE_ERROR to avoid dying silently

Summary:
Ref T12190. Ref T13187. I accidentally double-defined a method, which caused arc unit to exit silently under PHP 7.1.16.

Under this version of PHP, at least, this error raises an E_COMPILE_ERROR inside include_once() and never returns.

Test Plan:

Double define a testWhatever() method under PHP 7.1.16.
Run arc unit --everything.
Before patch: silent fatal.
After patch: useful error.

Reviewers: amckinley

Maniphest Tasks: T13187, T12190

Differential Revision: https://secure.phabricator.com/D19602

Details

Provenance

epriestley	Authored on Aug 24 2018, 5:45 PM
epriestley	Pushed on Aug 24 2018, 5:58 PM

Differential Revision

D19602: When including files, also print E_COMPILE_ERROR to avoid dying silently

Parents

rPHU5b341cc09ca9: Fix Filesytem::walkToRoot() on Windows with default ("/") root

Branches

Unknown

Tags

Unknown

Tasks

T13187: Plans: 2018 Week 34 Bonus Content
T12190: In PHP7, include-time warnings from source files are ignored

Build Status

Buildable 20667
Build 28089: Run Core Tests

Event Timeline

epriestley committed rPHUddc0e031461b: When including files, also print E_COMPILE_ERROR to avoid dying silently (authored by epriestley).Aug 24 2018, 5:58 PM

epriestley added a task: T13187: Plans: 2018 Week 34 Bonus Content.

epriestley added a task: T12190: In PHP7, include-time warnings from source files are ignored.

Harbormaster completed building B20667: rPHUddc0e031461b: When including files, also print E_COMPILE_ERROR to avoid dying silently.Aug 24 2018, 5:58 PM

epriestley mentioned this in 2018 Week 34 (Very Late August).Aug 25 2018, 12:43 AM

Changes (1)

Path

Size

src/

moduleutils/

PhutilBootloader.php

rPHUddc0e031461b

src/moduleutils/PhutilBootloader.php

Loading...