Page MenuHomePhabricator

When including files, also print E_COMPILE_ERROR to avoid dying silently
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:47 PM.
Tags
None
Referenced Files
F10887255: D19602.diff
Sat, Jul 2, 9:48 AM
Unknown Object (File)
Sat, Jul 2, 6:14 AM
Unknown Object (File)
Fri, Jun 24, 7:21 AM
Unknown Object (File)
Mon, Jun 20, 7:59 PM
Unknown Object (File)
Wed, Jun 15, 10:40 PM
Unknown Object (File)
Wed, Jun 15, 2:21 PM
Unknown Object (File)
Sun, Jun 12, 10:07 AM
Unknown Object (File)
Sat, Jun 11, 4:33 AM
Subscribers
None

Details

Summary

Ref T12190. Ref T13187. I accidentally double-defined a method, which caused arc unit to exit silently under PHP 7.1.16.

Under this version of PHP, at least, this error raises an E_COMPILE_ERROR inside include_once() and never returns.

Test Plan
  • Double define a testWhatever() method under PHP 7.1.16.
  • Run arc unit --everything.
  • Before patch: silent fatal.
  • After patch: useful error.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.