Paths

Table of Contentst

Differential D19602

When including files, also print E_COMPILE_ERROR to avoid dying silently
ClosedPublic
Actions

Authored by epriestley on Aug 24 2018, 5:47 PM.

Tags

None

Referenced Files

	F13081947: D19602.diff
	Wed, Apr 24, 9:55 PM

	Unknown Object (File)
	Mon, Apr 22, 10:09 PM

	Unknown Object (File)
	Sun, Apr 21, 3:52 PM

	Unknown Object (File)
	Sat, Apr 20, 7:02 AM

	Unknown Object (File)
	Fri, Apr 19, 7:52 PM

	Unknown Object (File)
	Wed, Apr 17, 2:54 PM

	Unknown Object (File)
	Thu, Apr 11, 4:19 PM

	Unknown Object (File)
	Thu, Apr 11, 7:08 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12190: In PHP7, include-time warnings from source files are ignored
T13187: Plans: 2018 Week 34 Bonus Content

Commits

rPHUd5dde4c2dbb7: (stable) Promote 2018 Week 34
rPHUddc0e031461b: When including files, also print E_COMPILE_ERROR to avoid dying silently

Summary

Ref T12190. Ref T13187. I accidentally double-defined a method, which caused arc unit to exit silently under PHP 7.1.16.

Under this version of PHP, at least, this error raises an E_COMPILE_ERROR inside include_once() and never returns.

Test Plan

Double define a testWhatever() method under PHP 7.1.16.
Run arc unit --everything.
Before patch: silent fatal.
After patch: useful error.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 24 2018, 5:47 PM

Harbormaster completed remote builds in B20665: Diff 46864.Aug 24 2018, 5:47 PM

epriestley requested review of this revision.Aug 24 2018, 5:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:58 PM

Closed by commit rPHUddc0e031461b: When including files, also print E_COMPILE_ERROR to avoid dying silently (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

moduleutils/

PhutilBootloader.php

6 lines

Diff 46866

src/moduleutils/PhutilBootloader.php

Loading...