HomePhabricator

Consolidate binary (hg, git, svn) analysis code into one place

Description

Consolidate binary (hg, git, svn) analysis code into one place

Summary:
Ref T12942. Currently, we have a bunch of code spread out all over the place for doing version tests on hg, svn, and git.

Consolidate this code a bit so we can use it to drive a new section on the "Version Information" page showing the installed versions (and paths) for binaries.

The primary goal is to reduce the support burden a little bit. Two particular issues are:

  • Various stuff with old (or new) VCS binaries, mostly Mercurial.
  • Cases where the webserver sees a different binary than sudoers specifies.

These should be easier to spot with binaries in the version info.

Test Plan:
Added unit tests, see also next change. Eventual result is this:

Screen Shot 2017-07-31 at 12.14.42 PM.png (341×777 px, 101 KB)

Reviewers: chad, avivey

Reviewed By: chad, avivey

Subscribers: avivey

Maniphest Tasks: T12942

Differential Revision: https://secure.phabricator.com/D18305

Details

Provenance
epriestleyAuthored on Jul 31 2017, 6:24 PM
epriestleyPushed on Aug 1 2017, 2:14 PM
Reviewer
chad
Differential Revision
D18305: Consolidate binary (hg, git, svn) analysis code into one place
Parents
rPHU0a4487d37cd7: Don't warn about use of "Throwable" under PHP5
Branches
Unknown
Tags
Unknown
Tasks
T12942: Add a "Binary Versions" page to Config
Build Status
Buildable 17859
Build 23988: Run Core Tests