Fix a mid-air collision around SearchService roles
Audited8879118b696f
Actions

Description

Fix a mid-air collision around SearchService roles

My D17571 didn't interact nicely with D17564, which added callsites for one of
the methods I removed.

Auditors: 20after4

Details

Auditors

joshuaspence
20after4
chad

Group Auditors

Cowboy Commits

Provenance

epriestley	Authored on Mar 28 2017, 8:59 PM
epriestley	Pushed on Mar 28 2017, 9:01 PM

Parents

rPc40be811ea9b: Fix isReadable() and isWritable() in SearchService

Branches

Unknown

Tags

Unknown

Build Status

Buildable 16207
Build 21519: Run Core Tests

Event Timeline

epriestley committed rP8879118b696f: Fix a mid-air collision around SearchService roles (authored by epriestley).Mar 28 2017, 9:01 PM

epriestley added an auditor: 20after4.

This commit now requires audit.Mar 28 2017, 9:01 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMar 28 2017, 9:01 PM

epriestley mentioned this in rPc40be811ea9b: Fix isReadable() and isWritable() in SearchService.Mar 28 2017, 9:02 PM

Harbormaster completed building B16207: rP8879118b696f: Fix a mid-air collision around SearchService roles.Mar 28 2017, 9:02 PM

joshuaspence accepted this commit.Mar 28 2017, 9:19 PM

chad accepted this commit.Mar 28 2017, 9:30 PM

20after4 accepted this commit.Mar 28 2017, 10:13 PM

All concerns with this commit have now been addressed.Mar 28 2017, 10:13 PM

Changes (1)

Path

Size

src/

infrastructure/

cluster/

search/

PhabricatorSearchService.php

rP8879118b696f

View Options

src/infrastructure/cluster/search/PhabricatorSearchService.php