Page MenuHomePhabricator

Fix isReadable() and isWritable() in SearchService
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:51 PM.
Tags
None
Referenced Files
F18869480: D17571.id.diff
Nov 4 2025, 12:00 PM
F18857439: D17571.diff
Nov 1 2025, 3:22 PM
F18856731: D17571.id.diff
Nov 1 2025, 11:18 AM
F18836746: D17571.diff
Oct 27 2025, 3:28 AM
F18835287: D17571.id42281.diff
Oct 26 2025, 2:46 PM
F18813576: D17571.id42274.diff
Oct 20 2025, 5:34 PM
F18679078: D17571.id.diff
Sep 26 2025, 12:31 AM
F18647218: D17571.diff
Sep 19 2025, 12:41 PM
Subscribers
None

Details

Summary

Ref T12450. Minor cleanup:

  • setRoles() has no callers.
  • getRoles() has no callers (these two methods are leftovers from an earlier iteration of the change).
  • The hasRole() logic doesn't work since nothing calls setRole().
  • hasRole() has only isreadable/iswritable as callers.
  • The isReadable()/isWritable() logic doesn't work since hasRole() doesn't work.

Instead, just check if there are any readable/writable hosts. Host already inherits its config from Service so this gets the same answer without any fuss.

Also add some read/write constants to make grepping this stuff a little easier.

Test Plan
  • Grepped for all removed symbols, saw only newer-generation calls in Host.
  • See next diff for use of isWritable().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable