Page MenuHomePhabricator

Fix isReadable() and isWritable() in SearchService
ClosedPublic

Authored by epriestley on Mar 28 2017, 7:51 PM.
Tags
None
Referenced Files
F17631427: D17571.diff
Thu, Jul 10, 1:06 PM
Unknown Object (File)
Mon, Jun 30, 3:58 AM
Unknown Object (File)
Mon, Jun 30, 1:57 AM
Unknown Object (File)
Sun, Jun 29, 6:26 AM
Unknown Object (File)
May 29 2025, 9:12 AM
Unknown Object (File)
May 19 2025, 11:33 AM
Unknown Object (File)
May 18 2025, 3:52 PM
Unknown Object (File)
May 10 2025, 11:38 PM
Subscribers
None

Details

Summary

Ref T12450. Minor cleanup:

  • setRoles() has no callers.
  • getRoles() has no callers (these two methods are leftovers from an earlier iteration of the change).
  • The hasRole() logic doesn't work since nothing calls setRole().
  • hasRole() has only isreadable/iswritable as callers.
  • The isReadable()/isWritable() logic doesn't work since hasRole() doesn't work.

Instead, just check if there are any readable/writable hosts. Host already inherits its config from Service so this gets the same answer without any fuss.

Also add some read/write constants to make grepping this stuff a little easier.

Test Plan
  • Grepped for all removed symbols, saw only newer-generation calls in Host.
  • See next diff for use of isWritable().

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable