HomePhabricator

Replace subscribe/unsubscribe for projects with explicit mail setting

Tags
None
Referenced Files
F1064931: Screen Shot 2016-01-19 at 7.05.29 PM.png
Jan 20 2016, 3:39 AM
F1064930: Screen Shot 2016-01-19 at 7.05.27 PM.png
Jan 20 2016, 3:39 AM
F1064929: Screen Shot 2016-01-19 at 7.05.25 PM.png
Jan 20 2016, 3:39 AM
Subscribers
None

Description

Replace subscribe/unsubscribe for projects with explicit mail setting

Summary:
Ref T10054. Ref T6113. Users can currently subscribe to projects, which causes them to receive:

  1. mail about project membership changes, description changes, etc; and
  2. mail to the project, e.g. when the project is added as a subscriber on a task, or a reviewer on a revision.

Almost no one cares about (1), and after D15061 you can use Herald to get this stuff if you really want it. (It will get progressively more annoying in the future with external membership sources causing automated project membership updates.)

A lot of users are confused about (2) and how it relates to membership, watching, etc, and most users who want (2) don't want (1).

Instead, add an explicit option for this and explain what it does.

This is fairly verbose but I've hidden it on the member/watch screen, which is now the "explain how projects work" screen, I guess.

Test Plan:

Screen Shot 2016-01-19 at 7.05.25 PM.png (1×1 px, 171 KB)

Screen Shot 2016-01-19 at 7.05.27 PM.png (1×1 px, 160 KB)

Screen Shot 2016-01-19 at 7.05.29 PM.png (1×1 px, 172 KB)

  • Disabled/enabled mail for a project.
  • Sent mail to a project with mail disabled, verified I didn't get a copy.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6113, T10054

Differential Revision: https://secure.phabricator.com/D15065