Diffusion Phabricator 5c2e49a81223

Allow any user to watch any project they can see
5c2e49a81223
Actions

Tags

None

Referenced Files

	F1064909: Screen Shot 2016-01-19 at 5.52.07 PM.png
	Jan 20 2016, 3:38 AM

Subscribers

None

Description

Allow any user to watch any project they can see

Summary:
Ref T6183. Ref T10054. Historically, only members could watch projects because there were some weird special cases with policies. These policy issues have been resolved and Herald is generally powerful enough to do equivalent watches on most objects anyway.

Also puts a "Watch Project" button on the feed panel to make the behavior and meaning more obvious.

Test Plan:

Watched a project I was not a member of.
Clicked the feed watch/unwatch button.

Screen Shot 2016-01-19 at 5.52.07 PM.png (349×897 px, 44 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6183, T10054

Differential Revision: https://secure.phabricator.com/D15063

Details

Provenance

epriestley	Authored on Jan 20 2016, 1:43 AM
epriestley	Pushed on Jan 20 2016, 3:38 AM

Reviewer

Differential Revision

D15063: Allow any user to watch any project they can see

Parents

rP01afb50406f2: Allow project editors to remove watchers

Branches

Unknown

Tags

Unknown

Tasks

T10054: Define product direction for Project/Profile UIs
T6183: Allow any user to watch projects

Build Status

Buildable 10217
Build 12419: Run Core Tests

Event Timeline

epriestley committed rP5c2e49a81223: Allow any user to watch any project they can see (authored by epriestley).Jan 20 2016, 3:38 AM

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

epriestley added a task: T6183: Allow any user to watch projects.

Harbormaster completed building B10217: rP5c2e49a81223: Allow any user to watch any project they can see.Jan 20 2016, 3:39 AM

Changes (32)

Path

Size

src/

applications/

badges/

storage/

PhabricatorBadgesBadge.php

calendar/

storage/

PhabricatorCalendarEvent.php

countdown/

storage/

PhabricatorCountdown.php

differential/

storage/

DifferentialRevision.php

files/

storage/

PhabricatorFile.php

fund/

storage/

FundInitiative.php

harbormaster/

storage/

configuration/

HarbormasterBuildPlan.php

herald/

storage/

legalpad/

storage/

LegalpadDocument.php

macro/

storage/

PhabricatorFileImageMacro.php

maniphest/

storage/

ManiphestTask.php

passphrase/

storage/

PassphraseCredential.php

paste/

storage/

PhabricatorPaste.php

phame/

storage/

pholio/

storage/

phriction/

storage/

PhrictionDocument.php

phurl/

storage/

PhabricatorPhurlURL.php

ponder/

storage/

PonderAnswer.php

PonderQuestion.php

project/

controller/

PhabricatorProjectMembersViewController.php

PhabricatorProjectProfileController.php

PhabricatorProjectWatchController.php

editor/

PhabricatorProjectTransactionEditor.php

storage/

PhabricatorProject.php

view/

PhabricatorProjectUserListView.php

repository/

storage/

PhabricatorRepositoryCommit.php

slowvote/

storage/

PhabricatorSlowvotePoll.php

subscriptions/

controller/

PhabricatorSubscriptionsEditController.php

events/

PhabricatorSubscriptionsUIEventListener.php

interface/

PhabricatorSubscribableInterface.php

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerBulkJob.php

rP5c2e49a81223

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/fund/storage/FundInitiative.php

Loading...

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...

src/applications/herald/storage/HeraldRule.php

Loading...

src/applications/legalpad/storage/LegalpadDocument.php

Loading...

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/passphrase/storage/PassphraseCredential.php

Loading...

src/applications/paste/storage/PhabricatorPaste.php

Loading...

src/applications/phame/storage/PhameBlog.php

Loading...

src/applications/phame/storage/PhamePost.php

Loading...

src/applications/pholio/storage/PholioMock.php

Loading...

src/applications/phriction/storage/PhrictionDocument.php

Loading...

src/applications/phurl/storage/PhabricatorPhurlURL.php

Loading...

src/applications/ponder/storage/PonderAnswer.php

Loading...

src/applications/ponder/storage/PonderQuestion.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/project/view/PhabricatorProjectUserListView.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...

src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php

Loading...

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...

src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Loading...