Page MenuHomePhabricator

Add Herald support for projects
ClosedPublic

Authored by epriestley on Jan 20 2016, 1:23 AM.
Tags
None
Referenced Files
F15537752: D15061.id36370.diff
Thu, Apr 24, 3:32 PM
F15516006: D15061.id.diff
Fri, Apr 18, 3:16 PM
F15513526: D15061.id36370.diff
Thu, Apr 17, 7:34 PM
F15512025: D15061.diff
Thu, Apr 17, 7:23 AM
F15427442: D15061.diff
Mar 23 2025, 2:31 PM
F15425090: D15061.id36380.diff
Mar 23 2025, 2:26 AM
F15418658: D15061.id36380.diff
Mar 21 2025, 12:39 AM
F15407412: D15061.id.diff
Mar 18 2025, 5:26 PM
Subscribers
None

Details

Summary

Ref T10054. Ref T6113. I'm going to remove subscribers from projects to fix the confusion between "watch" and "subscribe".

Users who have unusual use cases where they legitimately want to know when a project's description is updated or members change can use Herald to follow it.

This is also useful in general and improves consistency, although I don't have too many use cases for it.

Test Plan

Wrote a Herald rule, edited a project, saw the rule fire and send me email about the change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add Herald support for projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 1:42 AM

Oh, actually, I can't just remove subscribers because they still control whether you're part of the recipients when a project is subscribed or used as a reviewer or auditor. That's also not the same as watching.

I may replace that with a more obvious, dedicated "Send me mail which is sent to this project" option or something eventually. I'll probably just leave it as-is and document it for now.