Page MenuHomePhabricator

Replace subscribe/unsubscribe for projects with explicit mail setting
ClosedPublic

Authored by epriestley on Jan 20 2016, 3:11 AM.

Details

Summary

Ref T10054. Ref T6113. Users can currently subscribe to projects, which causes them to receive:

  1. mail about project membership changes, description changes, etc; and
  2. mail to the project, e.g. when the project is added as a subscriber on a task, or a reviewer on a revision.

Almost no one cares about (1), and after D15061 you can use Herald to get this stuff if you really want it. (It will get progressively more annoying in the future with external membership sources causing automated project membership updates.)

A lot of users are confused about (2) and how it relates to membership, watching, etc, and most users who want (2) don't want (1).

Instead, add an explicit option for this and explain what it does.

This is fairly verbose but I've hidden it on the member/watch screen, which is now the "explain how projects work" screen, I guess.

Test Plan

  • Disabled/enabled mail for a project.
  • Sent mail to a project with mail disabled, verified I didn't get a copy.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley retitled this revision from to Replace subscribe/unsubscribe for projects with explicit mail setting.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Make watchers receive even more mail (consistent with old rules).
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 3:27 AM
This revision was automatically updated to reflect the committed changes.