HomePhabricator

Fix two minor timezone display issues

Description

Fix two minor timezone display issues

Summary:
Ref T13263. Two minor issues:

  • The "reconcile" dialog shows the wrong sign because JS signs differ from normal signs (for example, PST or PDT or whatever we're in right now is shown as "UTC+7", but should be "UTC-7").
  • The big dropdown of possible timezones lumps "UTC+X:30" timezones into "UTC+X".

Test Plan:

  • Reconciled "America/Nome", saw negative UTC offsets for "America/Nome" and "America/Los_Angeles" (previously: improperly positive).
  • Viewed the big timzone list, saw ":30" and ":45" timezones grouped/labeled more accurately.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13263

Differential Revision: https://secure.phabricator.com/D20314

Details

Provenance
epriestleyAuthored on Mar 22 2019, 10:04 PM
epriestleyPushed on Mar 25 2019, 5:53 PM
Reviewer
amckinley
Differential Revision
D20314: Fix two minor timezone display issues
Parents
rP2ebe675ae5ec: Fix an unusual internal cursor in Conpherence
Branches
Unknown
Tags
Unknown
Tasks
T13263: Plans: 2019 Week 11-15 Bonus Content
Build Status
Buildable 22351
Build 30582: Run Core Tests