HomePhabricator

Fix an unusual internal cursor in Conpherence

Description

Fix an unusual internal cursor in Conpherence

Summary:
See https://discourse.phabricator-community.org/t/error-when-sending-a-message-chat-room/2548.

Conpherence calls setAfterID() and setBeforeID() directly on a subquery, but these methods no longer exist.

Use a pager instead. This code probably shouldn't exist (we should use some other approach to fetch this data in most cases) but that's a larger change.

Test Plan: Sent messages in a Conpherence thread. Before: fatal; after: success. Viewed the Conphrence menu, loaded threads, etc.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20318

Details

Provenance
epriestleyAuthored on Mar 24 2019, 8:56 PM
epriestleyPushed on Mar 25 2019, 5:53 PM
Reviewer
amckinley
Differential Revision
D20318: Fix an unusual internal cursor in Conpherence
Parents
rP7f90570636af: When paging by Ferret "rank", page using "HAVING rank > ...", not "WHERE rank >…
Branches
Unknown
Tags
Unknown
Build Status
Buildable 22349
Build 30580: Run Core Tests