HomePhabricator

Improve search highlighting for CJK and substring queries

Description

Improve search highlighting for CJK and substring queries

Summary:
Fixes T12995. Currently, the result highlighter (which shows where terms matched) only works in "term" mode, not in "substring" mode.

Provide better feedback and behvaior:

  • When a term is a substring term, color it a little differently and add a tooltip. (This is partly to make it easier to debug/diagnose things, probably not enormously valuable to users.)
  • When a term is a substring term, highlight it anywhere in the results.

Test Plan:
Queried for latin and CJK terms.

Here is CJK being highlighted:

Screen Shot 2017-09-22 at 8.08.26 AM.png (661×550 px, 56 KB)

Here is substring vs non-substring implicit behavior:

Screen Shot 2017-09-22 at 8.08.34 AM.png (490×515 px, 36 KB)

Here's ONLY terms being highlighted:

Screen Shot 2017-09-22 at 8.09.57 AM.png (570×523 px, 51 KB)

Here's terms and substrings, since the query now has a substring:

Screen Shot 2017-09-22 at 8.10.01 AM.png (579×539 px, 54 KB)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12995

Differential Revision: https://secure.phabricator.com/D18635