Page MenuHomePhabricator

Improve search highlighting for CJK and substring queries
ClosedPublic

Authored by epriestley on Sep 22 2017, 3:15 PM.
Tags
None
Referenced Files
F17706188: D18635.id44742.diff
Wed, Jul 16, 11:06 AM
F17695174: D18635.id.diff
Tue, Jul 15, 12:42 PM
F17693041: D18635.id44743.diff
Tue, Jul 15, 5:40 AM
F17685611: D18635.diff
Mon, Jul 14, 3:31 AM
Unknown Object (File)
May 26 2025, 1:18 AM
Unknown Object (File)
May 24 2025, 8:47 PM
Unknown Object (File)
May 7 2025, 1:43 AM
Unknown Object (File)
May 6 2025, 7:04 PM
Subscribers
None

Details

Summary

Fixes T12995. Currently, the result highlighter (which shows where terms matched) only works in "term" mode, not in "substring" mode.

Provide better feedback and behvaior:

  • When a term is a substring term, color it a little differently and add a tooltip. (This is partly to make it easier to debug/diagnose things, probably not enormously valuable to users.)
  • When a term is a substring term, highlight it anywhere in the results.
Test Plan

Queried for latin and CJK terms.

Here is CJK being highlighted:

Screen Shot 2017-09-22 at 8.08.26 AM.png (661×550 px, 56 KB)

Here is substring vs non-substring implicit behavior:

Screen Shot 2017-09-22 at 8.08.34 AM.png (490×515 px, 36 KB)

Here's ONLY terms being highlighted:

Screen Shot 2017-09-22 at 8.09.57 AM.png (570×523 px, 51 KB)

Here's terms and substrings, since the query now has a substring:

Screen Shot 2017-09-22 at 8.10.01 AM.png (579×539 px, 54 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks good (minus nit), assuming lint is a false positive.

src/applications/search/view/PhabricatorSearchResultView.php
130

"correctly"

This revision is now accepted and ready to land.Sep 22 2017, 6:08 PM
  • Use more conventional grammar.
This revision was automatically updated to reflect the committed changes.