Page MenuHomePhabricator

In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
ClosedPublic

Authored by epriestley on Apr 21 2018, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 4:00 PM
Unknown Object (File)
Thu, Jan 16, 7:01 AM
Unknown Object (File)
Sun, Jan 12, 2:42 PM
Unknown Object (File)
Fri, Jan 10, 6:29 PM
Unknown Object (File)
Sun, Jan 5, 11:53 AM
Unknown Object (File)
Mon, Dec 30, 9:19 AM
Unknown Object (File)
Sun, Dec 29, 1:03 PM
Unknown Object (File)
Sat, Dec 28, 5:55 PM
Subscribers
None

Details

Summary

Ref T13130. See PHI483. Currently, "Plan Changes + Draft" uses rules like "Plan Changes", not rules like "Draft", and allows "Accept".

This isn't consistent with how "Draft" and "Accept" work in other cases. Make "Plan Changes + Draft" more like "Draft" for consistency.

Also fix a string that didn't have a natural English version.

Test Plan
  • Added a failing build plan.
  • Created a revision.
  • Loaded the revision before builds completed, saw a nicer piece of text about "waiting for builds" instead of "waiting for 2 build(s)".
  • Builds failed, which automatically demoted the reivsion to "Changes Planned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense (particularly, no "Accept").
  • Abandoned the revision to test "Abandoned + Draft".
  • As the author and as a reviewer, verified all the actions available to me made sense.
  • Reclaimed the revision, then used "Request Review" to send it to "Needs Review". Verified that actions made sense and, e.g., reviewers could now "Accept" normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable