HomePhabricator

Make "line" and "char" strictly optional in ArcanistLintMessage

Description

Make "line" and "char" strictly optional in ArcanistLintMessage

Summary: See PHI136. These are already optional on the server side in HarbormasterBuildLintMessage, and effectively mean "file-level issue", which is a bit niche but not unreasonable.

Test Plan: Checked that HarbormasterBuildLintMessage doesn't care if these keys exist, created this revision.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18711

Details

Provenance
epriestleyAuthored on Oct 17 2017, 9:20 PM
epriestleyPushed on Oct 17 2017, 9:30 PM
Reviewer
amckinley
Differential Revision
D18711: Make "line" and "char" strictly optional in ArcanistLintMessage
Parents
rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0"
Branches
Unknown
Tags
Unknown
Build Status
Buildable 18701
Build 25193: Run Core Tests