Make "line" and "char" strictly optional in ArcanistLintMessage
ClosedPublic
Actions

Authored by epriestley on Oct 17 2017, 9:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 7, 9:12 AM

	Unknown Object (File)
	Tue, Apr 2, 8:38 AM

	Unknown Object (File)
	Tue, Apr 2, 8:38 AM

	Unknown Object (File)
	Tue, Apr 2, 8:38 AM

	Unknown Object (File)
	Tue, Mar 26, 2:23 AM

	Unknown Object (File)
	Mar 24 2024, 11:34 PM

	Unknown Object (File)
	Mar 24 2024, 3:39 PM

	Unknown Object (File)
	Feb 29 2024, 3:42 PM

View All 86 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rARC617c2e46d6a5: Make "line" and "char" strictly optional in ArcanistLintMessage

Summary

See PHI136. These are already optional on the server side in HarbormasterBuildLintMessage, and effectively mean "file-level issue", which is a bit niche but not unreasonable.

Test Plan

Checked that HarbormasterBuildLintMessage doesn't care if these keys exist, created this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 17 2017, 9:23 PM

Harbormaster completed remote builds in B18699: Diff 44921.Oct 17 2017, 9:24 PM

amckinley accepted this revision.Oct 17 2017, 9:24 PM

This revision is now accepted and ready to land.Oct 17 2017, 9:24 PM

Closed by commit rARC617c2e46d6a5: Make "line" and "char" strictly optional in ArcanistLintMessage (authored by epriestley). · Explain WhyOct 17 2017, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

ArcanistLintMessage.php

11 lines

Diff 44923

View Options

src/lint/ArcanistLintMessage.php

Make "line" and "char" strictly optional in ArcanistLintMessageClosedPublicActions