Page MenuHomePhabricator

Make "line" and "char" strictly optional in ArcanistLintMessage
ClosedPublic

Authored by epriestley on Oct 17 2017, 9:23 PM.
Tags
None
Referenced Files
F18812363: D18711.id44921.diff
Mon, Oct 20, 8:49 AM
F18807513: D18711.id44923.diff
Sun, Oct 19, 2:09 AM
F18738126: D18711.id.diff
Oct 1 2025, 2:13 PM
F18618435: D18711.diff
Sep 15 2025, 12:08 AM
F18250937: D18711.id44923.diff
Aug 21 2025, 5:18 PM
F17916578: D18711.diff
Jul 29 2025, 10:21 PM
Unknown Object (File)
Apr 29 2025, 5:30 AM
Unknown Object (File)
Apr 17 2025, 8:18 PM
Subscribers
None

Details

Summary

See PHI136. These are already optional on the server side in HarbormasterBuildLintMessage, and effectively mean "file-level issue", which is a bit niche but not unreasonable.

Test Plan

Checked that HarbormasterBuildLintMessage doesn't care if these keys exist, created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable