Fix parsing of Git branches with common and useful name "0"
76b54ce0a9af
Actions

Description

Fix parsing of Git branches with common and useful name "0"

Summary: See https://discourse.phabricator-community.org/t/arc-has-a-spurious-failure-on-arc-diff/521. Oh, PHP!

Test Plan: Created a branch named "0", ran arc diff. Before: fatal. After: this beautiful revision.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18678

Details

Provenance

epriestley	Authored on Oct 4 2017, 3:22 PM
epriestley	Pushed on Oct 4 2017, 5:20 PM

Reviewer

amckinley

Differential Revision

D18678: Fix parsing of Git branches with common and useful name "0"

Parents

rARCc804c5026011: Don't show a blank line if there is no user data

Branches

Unknown

Tags

Unknown

Build Status

Buildable 18628
Build 25095: Run Core Tests

Event Timeline

epriestley committed rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0" (authored by epriestley).Oct 4 2017, 5:20 PM

Harbormaster completed building B18628: rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0".Oct 4 2017, 5:21 PM

epriestley mentioned this in 2017 Week 40 (Early October).Oct 6 2017, 9:29 PM

epriestley mentioned this in 2017 Week 41 (Mid October).Oct 13 2017, 9:49 PM

• GoogleLegacy added a subscriber: • GoogleLegacy.Mar 5 2018, 7:52 AM

Changes (2)

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

workflow/

ArcanistLandWorkflow.php

rARC76b54ce0a9af

View Options

src/repository/api/ArcanistGitAPI.php