Omit "--" in older fallback commands for Git remote URIs
21a1828ea06c
Actions

Description

Omit "--" in older fallback commands for Git remote URIs

Summary: Ref T13481. Some older versions of Git appear to not support "--" in these commands. Just drop it. This can lead to ambiguous results with certain obviously-silly remote names, but doesn't appear to lead to anything dangerous.

Test Plan: Will followup with user on ancient Git.

Maniphest Tasks: T13481

Differential Revision: https://secure.phabricator.com/D20952

Details

Provenance

epriestley	Authored on Jan 24 2020, 12:37 AM
epriestley	Pushed on Jan 24 2020, 12:50 AM

Differential Revision

D20952: Omit "--" in older fallback commands for Git remote URIs

Parents

rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a…

Branches

Unknown

Tags

Unknown

Tasks

T13481: Don't require "git remote get-url" in Arcanist

Build Status

Buildable 23744
Build 32653: Run Core Tests

Event Timeline

epriestley committed rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs (authored by epriestley).Jan 24 2020, 12:50 AM

epriestley added an edge: D20952: Omit "--" in older fallback commands for Git remote URIs.

epriestley added a task: T13481: Don't require "git remote get-url" in Arcanist.

Harbormaster completed building B23744: rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs.Jan 24 2020, 12:51 AM

epriestley mentioned this in 2020 Week 5 (Very Late January).Jan 30 2020, 9:35 PM

epriestley mentioned this in 2020 Week 6 (Early February).Feb 12 2020, 7:33 PM

Changes (1)

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

rARC21a1828ea06c

View Options

src/repository/api/ArcanistGitAPI.php