Page MenuHomePhabricator

Omit "--" in older fallback commands for Git remote URIs
ClosedPublic

Authored by epriestley on Jan 24 2020, 12:39 AM.

Details

Summary

Ref T13481. Some older versions of Git appear to not support "--" in these commands. Just drop it. This can lead to ambiguous results with certain obviously-silly remote names, but doesn't appear to lead to anything dangerous.

Test Plan

Will followup with user on ancient Git.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 24 2020, 12:39 AM
epriestley requested review of this revision.Jan 24 2020, 12:39 AM
  • Only omit "--" in "git ls-remote", since it seems like it's okay for even very old "git config".

It's possible that "--" doesn't work in VERY VERY OLD "git config", but we can always drop it if a user with Rare Beta Git shows up.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 24 2020, 12:50 AM
This revision was automatically updated to reflect the committed changes.