Fri, Jan 17
Tue, Jan 14
Sep 25 2019
Sep 24 2019
Oh, no, that's unrelated:
Looking at this in slightly more detail, I think the immediate issue is just that .gitignore specifies /src/extensions/*, not /src/extensions/**.
I actually tried to use the extensions directory to hide Composer's vendored files and ran into this same issue.
Sep 16 2019
Sep 2 2019
Aug 30 2019
The operation in PHI1329 (against a ~8GB export) went through cleanly. Remaining work here is:
Aug 29 2019
This is something of an aside, but it would be nice to formalize PhutilConsoleProgressBar into a generic progress sink. A lot of bin/storage dump-related stuff could use this and bin/host download could obviously use it, and we likely have some use cases for reporting progress to the web via the API, but PhutilConsoleProgressBar lacks an indirection layer to really make this work cleanly.
My tentative plan is to add methods for sending the output to disk to HTTPSFuture, then go down the new parser pathway only if we're writing to disk. This should limit the amount of surface area exposed on the new parser.
Aug 28 2019
A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this?
According to curl/symbols-in-versions (this is a text file in the repository):
A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this? Only by hard-coding known-broken hostnames, I think?), and forcing it to use HTTP/1.1 could break those cases, so maybe I'll go spelunking here. I also can't immediately find a date of introduction for CURL_HTTP_VERSION_1_1 from the documentation.
Oct 2 2018
I believe this is essentially just T13209.
Sep 6 2018
D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).
Sep 4 2018
Mar 16 2018
Mar 5 2018
See T13098. I currently plan to expose the shell-complete workflow to every arc toolset, but I don't think being able to shell-complete bin/storage upgrade or similar is worth pursuing.
Jan 24 2018
Oct 3 2017
Not a problem - thanks for fixing that so quickly.
I can confirm that fixed the issue for us.
Oct 2 2017
Sep 30 2017
(I'll fix this if you don't get there first, but have used up all my brain energy for today. And thanks for the report!)
Would it be acceptable to change PhutilRemarkupHyperlinkRule to catch this exception and behave as if it were a non-whitelisted protocol? (Happy to draft the patch, just want to check before I do so)
This change creates a slight problem for us at KDE as we have some historical commits in our Subversion repository which have URLs in them which are invalid. This exception means that:
- Herald spins forever trying to process these commits, failing every single time (currently up to 855 failures).
- The commit can't be viewed in the browser (See https://phabricator.kde.org/R883:271607)
Sep 2 2017
Aug 25 2017
We haven't seen other users encounter this issue in several years.
No current plans to ever pursue this.