Page MenuHomePhabricator

libphutilProject
ActivePublic

Members (4)

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Fri, Jan 17

epriestley added a comment to T13395: Strip libphutil for parts.

See also https://discourse.phabricator-community.org/t/storage-upgrade-failed-class-phutilauthadapter-not-defined/3468.

Fri, Jan 17, 4:55 PM · libphutil

Tue, Jan 14

epriestley added a revision to T13395: Strip libphutil for parts: D20940: Move search query compiler / stemmer classes out of libphutil.
Tue, Jan 14, 7:48 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20939: Move search query parser/compiler classes to Phabricator.
Tue, Jan 14, 7:41 PM · libphutil

Sep 25 2019

epriestley added a revision to T13395: Strip libphutil for parts: D20838: Add "PhutilProseDiff" classes to "phabricator/".
Sep 25 2019, 9:40 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20837: Move PhutilProseDiff out of "libphutil/".
Sep 25 2019, 9:36 PM · libphutil

Sep 24 2019

epriestley closed T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map as Resolved by committing rPHU3b15fd0a01d4: Ignore all files in "src/extensions/", not just immediate children.
Sep 24 2019, 5:02 PM · libphutil
epriestley added a revision to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map: D20824: Ignore all files in "src/extensions/", not just immediate children.
Sep 24 2019, 4:40 PM · libphutil
epriestley added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

Oh, no, that's unrelated:

Sep 24 2019, 4:37 PM · libphutil
epriestley added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

Looking at this in slightly more detail, I think the immediate issue is just that .gitignore specifies /src/extensions/*, not /src/extensions/**.

Sep 24 2019, 4:36 PM · libphutil
jmeador added a comment to T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map.

I actually tried to use the extensions directory to hide Composer's vendored files and ran into this same issue.

Sep 24 2019, 4:33 PM · libphutil

Sep 16 2019

epriestley triaged T13418: "arc liberate" incorrectly includes subdirectories of "src/extensions/" in library map as Wishlist priority.
Sep 16 2019, 6:44 PM · libphutil

Sep 2 2019

epriestley added a revision to T13395: Strip libphutil for parts: D20774: Move web application classes into "phabricator/".
Sep 2 2019, 2:20 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: D20773: Remove "Web Application Only" classes from libphutil.
Sep 2 2019, 1:43 PM · libphutil
epriestley lowered the priority of T13396: Support downloads of 2GB+ files with HTTPSFuture from Normal to Wishlist.
Sep 2 2019, 1:11 PM · Infrastructure, libphutil

Aug 30 2019

epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

The operation in PHI1329 (against a ~8GB export) went through cleanly. Remaining work here is:

Aug 30 2019, 3:42 PM · Infrastructure, libphutil
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: Restricted Differential Revision.
Aug 30 2019, 2:12 AM · Infrastructure, libphutil

Aug 29 2019

epriestley triaged T13398: Merge "ExecFuture" and "PhutilExecPassthru" and support selective passthru of individual pipes as Low priority.
Aug 29 2019, 10:07 PM · Infrastructure, libphutil
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: Restricted Differential Revision.
Aug 29 2019, 7:03 PM · Infrastructure, libphutil
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: D20746: Add a rough "ProgressSink" for improved progress reporting flexibility.
Aug 29 2019, 7:00 PM · Infrastructure, libphutil
epriestley added a revision to T13396: Support downloads of 2GB+ files with HTTPSFuture: D20745: Allow HTTPSFuture to stream very large files directly to disk.
Aug 29 2019, 5:38 PM · Infrastructure, libphutil
epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

This is something of an aside, but it would be nice to formalize PhutilConsoleProgressBar into a generic progress sink. A lot of bin/storage dump-related stuff could use this and bin/host download could obviously use it, and we likely have some use cases for reporting progress to the web via the API, but PhutilConsoleProgressBar lacks an indirection layer to really make this work cleanly.

Aug 29 2019, 5:19 PM · Infrastructure, libphutil
epriestley added a comment to T13396: Support downloads of 2GB+ files with HTTPSFuture.

My tentative plan is to add methods for sending the output to disk to HTTPSFuture, then go down the new parser pathway only if we're writing to disk. This should limit the amount of surface area exposed on the new parser.

Aug 29 2019, 4:33 PM · Infrastructure, libphutil
epriestley claimed T13396: Support downloads of 2GB+ files with HTTPSFuture.
Aug 29 2019, 3:51 PM · Infrastructure, libphutil
epriestley created T13396: Support downloads of 2GB+ files with HTTPSFuture.
Aug 29 2019, 3:51 PM · Infrastructure, libphutil
epriestley triaged T13395: Strip libphutil for parts as Low priority.
Aug 29 2019, 3:41 PM · libphutil

Aug 28 2019

epriestley closed T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock as Resolved by committing rPHU5060bdf9726b: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:56 PM · Infrastructure, libphutil
epriestley added a revision to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock: D20744: Force HTTP/1.1 in HTTPSFuture until HTTP/2 support stabilizes.
Aug 28 2019, 6:55 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this?

Aug 28 2019, 6:51 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

According to curl/symbols-in-versions (this is a text file in the repository):

Aug 28 2019, 6:46 PM · Infrastructure, libphutil
epriestley added a comment to T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock.

A possible issue is that letting cURL pick a protocol might lead to it selecting HTTP/1.0 in some cases (how/when could it possibly do this? Only by hard-coding known-broken hostnames, I think?), and forcing it to use HTTP/1.1 could break those cases, so maybe I'll go spelunking here. I also can't immediately find a date of introduction for CURL_HTTP_VERSION_1_1 from the documentation.

Aug 28 2019, 6:44 PM · Infrastructure, libphutil
epriestley triaged T13391: Recent versions of cURL default to HTTP/2, but HTTP/2 is newfangled poppycock as Normal priority.
Aug 28 2019, 6:39 PM · Infrastructure, libphutil

Oct 2 2018

epriestley added a parent task for T9444: The function phutil_console_get_terminal_width needs to work with Windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:54 PM · Windows, libphutil
epriestley merged task T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows into T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · libphutil, Arcanist
epriestley closed T8821: arc commands (diff, version) fails on Windows - terrible fix inside as Resolved.

I believe this is essentially just T13209.

Oct 2 2018, 12:50 PM · Windows, libphutil, Arcanist
epriestley added a parent task for T8821: arc commands (diff, version) fails on Windows - terrible fix inside: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:49 PM · Windows, libphutil, Arcanist

Sep 6 2018

epriestley added a comment to T3130: Improve recognition of symbols in Java.

D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).

Sep 6 2018, 5:35 PM · Symbols, libphutil
avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil

Sep 4 2018

epriestley added a revision to T3130: Improve recognition of symbols in Java: D19637: Port the Java fragment lexer to PHP.
Sep 4 2018, 9:01 PM · Symbols, libphutil

Mar 16 2018

epriestley closed T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki as Resolved by committing rP2fa904921e1a: Render object monograms and embedding references more gracefully when building….
Mar 16 2018, 10:44 PM · libphutil, Remarkup
epriestley added a revision to T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki: D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.
Mar 16 2018, 10:37 PM · libphutil, Remarkup

Mar 5 2018

epriestley closed T7488: Add shell completion support to PhutilArgumentWorkflow as Wontfix.

See T13098. I currently plan to expose the shell-complete workflow to every arc toolset, but I don't think being able to shell-complete bin/storage upgrade or similar is worth pursuing.

Mar 5 2018, 2:10 PM · Restricted Project, libphutil

Jan 24 2018

epriestley moved T3130: Improve recognition of symbols in Java from Backlog to Language Support on the Symbols board.
Jan 24 2018, 5:38 PM · Symbols, libphutil

Oct 3 2017

bcooksley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

Not a problem - thanks for fixing that so quickly.
I can confirm that fixed the issue for us.

Oct 3 2017, 8:40 AM · libphutil, Security

Oct 2 2017

epriestley added a revision to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns: D18666: Fix an exception in the hyperlink remarkup rule for unparseable URIs.
Oct 2 2017, 2:14 PM · libphutil, Security

Sep 30 2017

epriestley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

(I'll fix this if you don't get there first, but have used up all my brain energy for today. And thanks for the report!)

Sep 30 2017, 10:35 PM · libphutil, Security
epriestley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

Would it be acceptable to change PhutilRemarkupHyperlinkRule to catch this exception and behave as if it were a non-whitelisted protocol? (Happy to draft the patch, just want to check before I do so)

Sep 30 2017, 10:32 PM · libphutil, Security
bcooksley added a comment to T12526: parse_url() behavior has changed with PHP7, causing libphutil unit tests to fail and possibly creating security concerns.

This change creates a slight problem for us at KDE as we have some historical commits in our Subversion repository which have URLs in them which are invalid. This exception means that:

  • Herald spins forever trying to process these commits, failing every single time (currently up to 855 failures).
  • The commit can't be viewed in the browser (See https://phabricator.kde.org/R883:271607)
Sep 30 2017, 9:27 PM · libphutil, Security

Sep 2 2017

chad shifted P1887 Arcanist Installation Shell Script for Linux from the S3 Hyperspace space to the S1 Core space.
Sep 2 2017, 11:57 PM · libphutil, Arcanist

Aug 25 2017

epriestley closed T6338: Use default ca path of curl if not defined otherwise as Wontfix.

We haven't seen other users encounter this issue in several years.

Aug 25 2017, 2:46 PM · libphutil
epriestley closed T5976: Handle the awful CLIXML output from Powershell on Windows as Wontfix.

No current plans to ever pursue this.

Aug 25 2017, 2:45 PM · libphutil, Harbormaster