Page MenuHomePhabricator

(T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste
Needs RevisionPublic

Authored by matmarex on Jan 27 2015, 6:50 AM.



Using HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.

This is not necessarily a complete proper patch, but it's worth reviewing in my opinion. Problems:

  • PhabricatorFileUploadDialogController is unused now and I'm scared to try deleting it.
  • This probably doesn't play very well with multiple Remarkup textareas on the page.
  • There is no way to discover drag&drop and copy&paste uploads now, without the warning dialog.
Test Plan

Try adding a comment, click the 'cloud' icon, use the file field that will appear.

Diff Detail

rP Phabricator
Lint Skipped
Tests Skipped
Build Status
Buildable 4070
Build 4083: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

matmarex retitled this revision from to (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste.
matmarex updated this object.
matmarex edited the test plan for this revision. (Show Details)
matmarex added a reviewer: epriestley.
matmarex set the repository for this revision to rP Phabricator.
matmarex added projects: Files, Remarkup.

We could desperately use this at to allow mobile phone & tablet users to upload screenshots. Any chance of getting review?

If something isn't a priority to build, it generally also isn't a priority to review or maintain: we would still be spending time on something low-priority instead of something high-priority. See "Not a Priority" in Contributing Code.

Obsoleted by upstream changes.

This revision now requires changes to proceed.Jan 11 2017, 3:36 PM