(T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste
Needs RevisionPublic
Actions

Authored by matmarex on Jan 27 2015, 6:50 AM.

Details

Reviewers

• peterquek1983
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5187: Make "Upload File" dialog have a vanilla file upload control

Summary

Using HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.

This is not necessarily a complete proper patch, but it's worth reviewing in my opinion. Problems:

PhabricatorFileUploadDialogController is unused now and I'm scared to try deleting it.
This probably doesn't play very well with multiple Remarkup textareas on the page.
There is no way to discover drag&drop and copy&paste uploads now, without the warning dialog.

Test Plan

Try adding a comment, click the 'cloud' icon, use the file field that will appear.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 4070
Build 4083: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

matmarex updated this revision to Diff 27691.Jan 27 2015, 6:50 AM

matmarex retitled this revision from to (T5187) Allow uploading files directly when editing a comment without drag&drop/copy&paste.

matmarex updated this object.

matmarex edited the test plan for this revision. (Show Details)

matmarex added a reviewer: epriestley.

matmarex set the repository for this revision to rP Phabricator.

matmarex added projects: Files, Remarkup.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 27 2015, 6:50 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

matmarex added a task: T5187: Make "Upload File" dialog have a vanilla file upload control.Jan 27 2015, 6:51 AM

Any feedback?

qgil added subscribers: 20after4, • chasemp.Feb 9 2015, 10:30 AM

qgil added a subscriber: qgil.

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 6:08 AM

eadler added a subscriber: eadler.Jun 12 2015, 5:06 AM

We could desperately use this at https://phabricator.wikimedia.org to allow mobile phone & tablet users to upload screenshots. Any chance of getting review?

If something isn't a priority to build, it generally also isn't a priority to review or maintain: we would still be spending time on something low-priority instead of something high-priority. See "Not a Priority" in Contributing Code.

epriestley mentioned this in T5187: Make "Upload File" dialog have a vanilla file upload control.May 20 2016, 1:12 PM

• peterquek1983 accepted this revision.Jun 8 2016, 1:25 PM

• peterquek1983 added a reviewer: • peterquek1983.